linux-kernel - Re: [PATCH] bus: qcom: ebi2: fix device node iterator leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYCw7hPZrfdJ4ETqNDGJm86x_mFd1smStGQAFGAKHroUQ@mail.gmail.com>
Date:   Tue, 29 Sep 2020 22:46:19 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Tobias Jordan <kernel@...e.de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     MSM <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Gross <agross@...nel.org>
Subject: Re: [PATCH] bus: qcom: ebi2: fix device node iterator leak

On Sat, Sep 26, 2020 at 1:45 AM Tobias Jordan <kernel@...e.de> wrote:

> In the for_each_available_child_of_node loop of qcom_ebi2_probe, add a
> call to of_node_put to avoid leaking the iterator if we bail out.
>
> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
>
> Signed-off-by: Tobias Jordan <kernel@...e.de>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Bjorn can you apply this to the Qualcomm SoC tree?

Yours,
Linus Walleij