linux-kernel - Re: [PATCH 7/8] arm64: dts: meson: enable RTC for VIM1 meson-gxl-s905x-khadas-vim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCC+iTScTc76aFmqJ0NyhKB9pVwqVjFqBQvcQPVBE34izQ@mail.gmail.com>
Date:   Fri, 25 Sep 2020 09:31:11 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Artem Lapkin <email2tema@...il.com>
Cc:     Neil Armstrong <narmstrong@...libre.com>, khilman@...libre.com,
        robh+dt@...nel.org, jbrunet@...libre.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        art@...das.com, nick@...das.com, gouwa@...das.com
Subject: Re: [PATCH 7/8] arm64: dts: meson: enable RTC for VIM1 meson-gxl-s905x-khadas-vim

Hi Artem,

On Fri, Sep 25, 2020 at 5:31 AM Artem Lapkin <email2tema@...il.com> wrote:
>
> enable RTC for VIM1 meson-gxl-s905x-khadas-vim
I think the commit message should always explain *why* the change is
necessary (what problem does it solve?)
for trivial changes the diff itself explains "what" is being changed

[...]
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
> index 8bcdffdf55d..354f21d4171 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
> @@ -98,7 +98,7 @@ &i2c_B {
>
>         rtc: rtc@51 {
>                 /* has to be enabled manually when a battery is connected: */
why do we need to keep this comment?

same feedback applies to patch 8


Best regards,
Martin