linux-kernel - Re: [PATCH 2/8] arm64: dts: meson: update leds node on Khadas VIM3/VIM3L boards meson-khadas-vim3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc2f38e4-70c9-032c-0a76-da055e98b632@baylibre.com>
Date:   Fri, 25 Sep 2020 09:36:20 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Artem Lapkin <email2tema@...il.com>
Cc:     khilman@...libre.com, robh+dt@...nel.org, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        art@...das.com, nick@...das.com, gouwa@...das.com
Subject: Re: [PATCH 2/8] arm64: dts: meson: update leds node on Khadas
 VIM3/VIM3L boards meson-khadas-vim3

On 25/09/2020 05:30, Artem Lapkin wrote:
> GPIO_ACTIVE_LOW replaced to GPIO_ACTIVE_HIGH for white and red leds
> 
> Signed-off-by: Artem Lapkin <art@...das.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> index 94f75b44650..73783692e30 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> @@ -41,13 +41,13 @@ leds {
>  
>  		led-white {
>  			label = "vim3:white:sys";
> -			gpios = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
> +			gpios = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "heartbeat";
>  		};
>  
>  		led-red {
>  			label = "vim3:red";
> -			gpios = <&gpio_expander 5 GPIO_ACTIVE_LOW>;
> +			gpios = <&gpio_expander 5 GPIO_ACTIVE_HIGH>;
>  		};
>  	};
>  
> 

This has already been fixed and applied for 5.10:
https://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git/commit/?h=v5.10/dt64&id=1f9d87d08e4a2299e86f8a1600aedf87ecd3b636

Neil