linux-kernel - Re: [PATCH] drm/vc4: Deleted the drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca931d2e-c445-a14a-cb40-a7d3f5c190e2@huawei.com>
Date:   Fri, 25 Sep 2020 17:16:19 +0800
From:   "tiantao (H)" <tiantao6@...wei.com>
To:     Tian Tao <tiantao6@...ilicon.com>, <eric@...olt.net>,
        <airlied@...ux.ie>, <sumit.semwal@...aro.org>,
        <christian.koenig@....com>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <linaro-mm-sig@...ts.linaro.org>
Subject: Re: [PATCH] drm/vc4: Deleted the drm_device declaration

Hi :
I alwaygs used scripts/get_maintainers.pl to get the recipient list.I 
don't know why miss maintainers for a given piece of code.

tiantao@...ntu:~$ git send-email -to eric@...olt.net -to 
airlied@...ux.ie -to daniel@...ll.ch -to sumit.semwal@...aro.org -to 
christian.koenig@....com -to dri-devel@...ts.freedesktop.org -to 
linux-kernel@...r.kernel.org -to linux-media@...r.kernel.org -to 
linaro-mm-sig@...ts.linaro.org 
mailline/drm/drm/0001-drm-vc4-Deleted-the-drm_device-declaration.patch 
--suppress-cc=all
mailline/drm/drm/0001-drm-vc4-Deleted-the-drm_device-declaration.patch

tiantao@...ntu:~/mailline/drm/drm$ vim drivers/gpu/drm/vc4/vc4_drv.h^C
tiantao@...ntu:~/mailline/drm/drm$ ./scripts/get_maintainer.pl 
drivers/gpu/drm/vc4/vc4_drv.h
Eric Anholt <eric@...olt.net> (supporter:DRM DRIVERS FOR VC4)
David Airlie <airlied@...ux.ie> (maintainer:DRM DRIVERS)
Daniel Vetter <daniel@...ll.ch> (maintainer:DRM DRIVERS)
Sumit Semwal <sumit.semwal@...aro.org> (maintainer:DMA BUFFER SHARING 
FRAMEWORK)
"Christian König" <christian.koenig@....com> (maintainer:DMA BUFFER 
SHARING FRAMEWORK)
dri-devel@...ts.freedesktop.org (open list:DRM DRIVERS)
linux-kernel@...r.kernel.org (open list)
linux-media@...r.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK)
linaro-mm-sig@...ts.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK)


在 2020/9/25 17:10, Daniel Vetter 写道:
> On Fri, Sep 25, 2020 at 04:51:38PM +0800, Tian Tao wrote:
>> drm_modeset_lock.h already declares struct drm_device, so there's no
>> need to declare it in vc4_drv.h
>>
>> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> 
> Just an aside, when submitting patches please use
> scripts/get_maintainers.pl to generate the recipient list. Looking through
> past few patches from you it seems fairly arbitrary and often misses the
> actual maintainers for a given piece of code, which increases the odds the
> patch will get lost a lot.
> 
> E.g. for this one I'm only like the 5th or so fallback person, and the
> main maintainer isn't on the recipient list.
> 
> Cheeers, Daniel
> 
>> ---
>>   drivers/gpu/drm/vc4/vc4_drv.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
>> index 8c8d96b..8717a1c 100644
>> --- a/drivers/gpu/drm/vc4/vc4_drv.h
>> +++ b/drivers/gpu/drm/vc4/vc4_drv.h
>> @@ -19,7 +19,6 @@
>>   
>>   #include "uapi/drm/vc4_drm.h"
>>   
>> -struct drm_device;
>>   struct drm_gem_object;
>>   
>>   /* Don't forget to update vc4_bo.c: bo_type_names[] when adding to
>> -- 
>> 2.7.4
>>
>