linux-kernel - Re: [PATCH v2] leds: tlc591xx: fix leak of device node iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200926032406.00c7cfb2@kernel.org>
Date:   Sat, 26 Sep 2020 03:24:06 +0200
From:   Marek Behún <kabel@...nel.org>
To:     Tobias Jordan <kernel@...e.de>
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        Jean-Jacques Hiblot <jjhiblot@...com>,
        Tomi Valkeinen <tomi.valkeinen@...com>
Subject: Re: [PATCH v2] leds: tlc591xx: fix leak of device node iterator

On Sat, 26 Sep 2020 02:51:17 +0200
Tobias Jordan <kernel@...e.de> wrote:

> In one of the error paths of the for_each_child_of_node loop in
> tlc591xx_probe, add missing call to of_node_put.
> 
> Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the
> managed led API")
> 
> Signed-off-by: Tobias Jordan <kernel@...e.de>
> ---
> v2: rebased to Pavel's for-next branch
> 
>  drivers/leds/leds-tlc591xx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
> index f24271337bd8..5b9dfdf743ec 100644
> --- a/drivers/leds/leds-tlc591xx.c
> +++ b/drivers/leds/leds-tlc591xx.c
> @@ -205,10 +205,12 @@ tlc591xx_probe(struct i2c_client *client,
>  		led->ldev.max_brightness = TLC591XX_MAX_BRIGHTNESS;
>  		err = devm_led_classdev_register_ext(dev, &led->ldev,
>  						     &init_data);
> -		if (err < 0)
> +		if (err < 0) {
> +			of_node_put(child);
>  			return dev_err_probe(dev, err,
>  					     "couldn't register LED %s\n",
>  					     led->ldev.name);
> +		}
>  	}
>  	return 0;
>  }

Reviewed-by: Marek Behún <kabel@...nel.org>