linux-kernel - Re: [PATCH v2] leds: tlc591xx: fix leak of device node iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200930171147.GG27760@duo.ucw.cz>
Date:   Wed, 30 Sep 2020 19:11:47 +0200
From:   Pavel Machek <pavel@....cz>
To:     Marek Behún <kabel@...nel.org>
Cc:     Tobias Jordan <kernel@...e.de>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, Dan Murphy <dmurphy@...com>,
        Jean-Jacques Hiblot <jjhiblot@...com>,
        Tomi Valkeinen <tomi.valkeinen@...com>
Subject: Re: [PATCH v2] leds: tlc591xx: fix leak of device node iterator

Hi!

> > In one of the error paths of the for_each_child_of_node loop in
> > tlc591xx_probe, add missing call to of_node_put.
> > 
> > Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the
> > managed led API")
> > 
> > Signed-off-by: Tobias Jordan <kernel@...e.de>
> 
> Reviewed-by: Marek Behún <kabel@...nel.org>

Thanks, applied.

Marek: Thanks for review. If I can get you to trim parts not
interesting for the email, I'll be even happier.

:-).

Best regards,

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)