linux-kernel - Re: [patch 28/35] net: iwlwifi: Remove in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab22cc7b0d1f98e1d620e77ce7abce1f95b6813e.camel@intel.com>
Date:   Mon, 28 Sep 2020 06:13:14 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "stf_xl@...pl" <stf_xl@...pl>,
        "torvalds@...uxfoundation.org" <torvalds@...uxfoundation.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "brcm80211-dev-list.pdl@...adcom.com" 
        <brcm80211-dev-list.pdl@...adcom.com>,
        "jcliburn@...il.com" <jcliburn@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux-net-drivers@...arflare.com" <linux-net-drivers@...arflare.com>,
        "libertas-dev@...ts.infradead.org" <libertas-dev@...ts.infradead.org>,
        "jdmason@...zu.us" <jdmason@...zu.us>,
        "dsd@...too.org" <dsd@...too.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "corbet@....net" <corbet@....net>,
        "luc.vanoostenryck@...il.com" <luc.vanoostenryck@...il.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "wright.feng@...ress.com" <wright.feng@...ress.com>,
        "amitkarwar@...il.com" <amitkarwar@...il.com>,
        "ganapathi.bhat@....com" <ganapathi.bhat@....com>,
        "brcm80211-dev-list@...ress.com" <brcm80211-dev-list@...ress.com>,
        "j@...fi" <j@...fi>,
        "tsbogend@...ha.franken.de" <tsbogend@...ha.franken.de>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        "mhabets@...arflare.com" <mhabets@...arflare.com>,
        "mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "snelson@...sando.io" <snelson@...sando.io>,
        "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
        "willy@...radead.org" <willy@...radead.org>,
        "chris.snook@...il.com" <chris.snook@...il.com>,
        "paulmck@...nel.org" <paulmck@...nel.org>,
        "vishal@...lsio.com" <vishal@...lsio.com>,
        "franky.lin@...adcom.com" <franky.lin@...adcom.com>,
        "stas.yakovlev@...il.com" <stas.yakovlev@...il.com>,
        "pterjan@...gle.com" <pterjan@...gle.com>,
        "_govind@....com" <_govind@....com>,
        "benve@...co.com" <benve@...co.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "chi-hsien.lin@...ress.com" <chi-hsien.lin@...ress.com>,
        "huxinming820@...il.com" <huxinming820@...il.com>,
        linuxwifi <linuxwifi@...el.com>,
        "ecree@...arflare.com" <ecree@...arflare.com>,
        "bigeasy@...utronix.de" <bigeasy@...utronix.de>,
        "drivers@...sando.io" <drivers@...sando.io>,
        "pkshih@...ltek.com" <pkshih@...ltek.com>,
        "kune@...ne-taler.de" <kune@...ne-taler.de>,
        "arend.vanspriel@...adcom.com" <arend.vanspriel@...adcom.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "hante.meuleman@...adcom.com" <hante.meuleman@...adcom.com>
Subject: Re: [patch 28/35] net: iwlwifi: Remove in_interrupt() from tracing
 macro.

On Sun, 2020-09-27 at 21:49 +0200, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> 
> The usage of in_interrupt) in driver code is phased out.
> 
> The iwlwifi_dbg tracepoint records in_interrupt() seperately, but that's
> superfluous because the trace header already records all kind of state and
> context information like hardirq status, softirq status, preemption count
> etc.
> 
> Aside of that the recording of in_interrupt() as boolean does not allow to
> distinguish between the possible contexts (hard interrupt, soft interrupt,
> bottom half disabled) while the trace header gives precise information.
> 
> Remove the duplicate information from the tracepoint and fixup the caller.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Johannes Berg <johannes.berg@...el.com>
> Cc: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
> Cc: Luca Coelho <luciano.coelho@...el.com>
> Cc: Intel Linux Wireless <linuxwifi@...el.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: linux-wireless@...r.kernel.org
> Cc: netdev@...r.kernel.org

Acked-by: Luca Coelho <luca@...lho.fi>

--
Luca.