linux-kernel - RE: [PATCH 4/5] misc: vop: set VIRTIO_F_ACCESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB4960189DE174E393B470AAA792350@VI1PR04MB4960.eurprd04.prod.outlook.com>
Date:   Mon, 28 Sep 2020 09:57:35 +0000
From:   Sherry Sun <sherry.sun@....com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "sudeep.dutt@...el.com" <sudeep.dutt@...el.com>,
        "ashutosh.dixit@...el.com" <ashutosh.dixit@...el.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "wang.yi59@....com.cn" <wang.yi59@....com.cn>,
        "rikard.falkeborn@...il.com" <rikard.falkeborn@...il.com>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 4/5] misc: vop: set VIRTIO_F_ACCESS_PLATFORM for
 nocoherent platform

Hi Christoph,

> On Sun, Sep 27, 2020 at 08:05:07AM +0000, Sherry Sun wrote:
> > Hi Christoph,
> >
> > > On Fri, Sep 25, 2020 at 03:26:29PM +0800, Sherry Sun wrote:
> > > > Set VIRTIO_F_ACCESS_PLATFORM feature for nocoherent platform,
> > > > since it needs the DMA API for virtio.
> > >
> > > Given that VOP is a plug-in PCIe card VIRTIO_F_ACCESS_PLATFORM must
> > > always be set, as the DMA mapping details are not something the
> > > virtio implementation decides on, but the host PCIe/iommu
> implementation.
> >
> > So do you mean that we should remove the check, and set
> VIRTIO_F_ACCESS_PLATFORM feature directly?
> 
> Yes.  In a separate prep patch.

Okay, will do it in V2.

Regards
Sherry