linux-kernel - Re: [PATCH v8 12/32] i2c: tegra: Use clk-bulk helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc8704c2-85bc-98ce-4765-c28ce8ac6be9@gmail.com>
Date:   Wed, 30 Sep 2020 00:01:40 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Wolfram Sang <wsa@...-dreams.de>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 12/32] i2c: tegra: Use clk-bulk helpers

29.09.2020 22:33, Wolfram Sang пишет:
> On Wed, Sep 23, 2020 at 01:51:35AM +0300, Dmitry Osipenko wrote:
>> Use clk-bulk helpers and factor out clocks initialization into separate
>> function in order to make code cleaner.
>>
>> The clocks initialization now performed after reset-control initialization
>> in order to avoid a noisy -PROBE_DEFER errors on T186+ from the clk-bulk
>> helper which doesn't silence this error code. Hence reset_control_get()
>> now may return -EPROBE_DEFER on newer Tegra SoCs because they use BPMP
>> driver that provides reset controls and BPMP doesn't come up early during
>> boot. Previously rst was protected by the clocks retrieval and now this
>> patch makes dev_err_probe() to be used for the rst error handling.
>>
>> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> 
> Any comments here? I'll apply this series later this week if there are
> no objections coming up.
> 

Please hold on, I just spotted a serious problem in patch 23 and v9
needs to be done.