linux-kernel - Re: [PATCH v8 23/32] i2c: tegra: Factor out packet header setup from tegra_i2c_xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Sep 2020 00:16:50 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 23/32] i2c: tegra: Factor out packet header setup from
 tegra_i2c_xfer_msg()

...
> +	tegra_i2c_push_packet_header(i2c_dev, msg, end_state);
>  
>  	if (!i2c_dev->msg_read) {
>  		if (i2c_dev->is_curr_dma_xfer) {
> -			memcpy(buffer, msg->buf, msg->len);
> +			memcpy(i2c_dev->dma_buf, msg->buf, msg->len);

I spotted that this now shall be i2c_dev->dma_buf + I2C_PACKET_HEADER_SIZE.

I also checked that the enforced DMA mode doesn't work using v8 and it
works fine after the fix. Will make v9 shortly.