linux-kernel - Re: [PATCH v2 1/9] iio: buffer: dmaengine: unwrap the use of iio_buffer_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Sep 2020 10:48:11 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Eugen Hristev <eugen.hristev@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        groeck@...omium.org,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH v2 1/9] iio: buffer: dmaengine: unwrap the use of iio_buffer_set_attrs()

On Tue, Sep 29, 2020 at 10:09 AM Alexandru Ardelean
<alexandru.ardelean@...log.com> wrote:
>
> The iio_buffer_set_attrs() helper will be removed in this series. So, just
> assign the attributes of the DMAEngine buffer logic directly.
>
> This is IIO buffer core context, so there is direct access to the
> buffer->attrs object.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> ---
>  drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> index 93b4e9e6bb55..becea9f68181 100644
> --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> @@ -200,8 +200,7 @@ static struct iio_buffer *iio_dmaengine_buffer_alloc(struct device *dev,
>
>         iio_dma_buffer_init(&dmaengine_buffer->queue, chan->device->dev,
>                 &iio_dmaengine_default_ops);
> -       iio_buffer_set_attrs(&dmaengine_buffer->queue.buffer,
> -               iio_dmaengine_buffer_attrs);
> +       dmaengine_buffer->queue.buffer.attrs = iio_dmaengine_buffer_attrs;
>
>         dmaengine_buffer->queue.buffer.access = &iio_dmaengine_buffer_ops;

A nit: can we group assignments together, like
init()
...blank line...
attr = ...
access = ...

?

>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko