linux-kernel - Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929083232.GA11648@pengutronix.de>
Date:   Tue, 29 Sep 2020 10:32:32 +0200
From:   Sascha Hauer <s.hauer@...gutronix.de>
To:     Richard Weinberger <richard@....at>
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Kristof Havasi <havasiefr@...il.com>
Subject: Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth
 nodes

On Mon, Sep 28, 2020 at 09:06:12PM +0200, Richard Weinberger wrote:
> When removing the last reference of an inode the size of an auth node
> is already part of write_len. So we must not call ubifs_add_auth_dirt().
> Call it only when needed.
> 
> Cc: <stable@...r.kernel.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Kristof Havasi <havasiefr@...il.com>
> Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal")
> Reported-by: Kristof Havasi <havasiefr@...il.com>
> Signed-off-by: Richard Weinberger <richard@....at>

Looked at the code until I understood what the problem is and how it is
fixed, so:

Reviewed-by: Sascha Hauer <s.hauer@...gutronix.de>

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |