linux-kernel - Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1641873979.143790.1601369073151.JavaMail.zimbra@nod.at>
Date:   Tue, 29 Sep 2020 10:44:33 +0200 (CEST)
From:   Richard Weinberger <richard@....at>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>,
        Kristof Havasi <havasiefr@...il.com>
Subject: Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth
 nodes

----- Ursprüngliche Mail -----
> Von: "Sascha Hauer" <s.hauer@...gutronix.de>
> An: "richard" <richard@....at>
> CC: "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-kernel" <linux-kernel@...r.kernel.org>, "stable"
> <stable@...r.kernel.org>, "Kristof Havasi" <havasiefr@...il.com>
> Gesendet: Dienstag, 29. September 2020 10:32:32
> Betreff: Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes

> On Mon, Sep 28, 2020 at 09:06:12PM +0200, Richard Weinberger wrote:
>> When removing the last reference of an inode the size of an auth node
>> is already part of write_len. So we must not call ubifs_add_auth_dirt().
>> Call it only when needed.
>> 
>> Cc: <stable@...r.kernel.org>
>> Cc: Sascha Hauer <s.hauer@...gutronix.de>
>> Cc: Kristof Havasi <havasiefr@...il.com>
>> Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal")
>> Reported-by: Kristof Havasi <havasiefr@...il.com>
>> Signed-off-by: Richard Weinberger <richard@....at>
> 
> Looked at the code until I understood what the problem is and how it is
> fixed, so:
> 
> Reviewed-by: Sascha Hauer <s.hauer@...gutronix.de>

Applied to fixes branch!

Thanks,
//richard