linux-kernel - Re: [PATCH] rcu,ftrace: Fix ftrace recursion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929144953.GP2628@hirez.programming.kicks-ass.net>
Date:   Tue, 29 Sep 2020 16:49:53 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Paul McKenney <paulmck@...nel.org>, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, kim.phillips@....com
Subject: Re: [PATCH] rcu,ftrace: Fix ftrace recursion

On Tue, Sep 29, 2020 at 10:36:20AM -0400, Steven Rostedt wrote:

> > +notrace bool rcu_is_watching(void)
> >  {
> >  	bool ret;
> >  
> 
> I think the patch I suggested is more suitable.

Both, with only your patch we'd still take the pointless mcount call,
which is then pure overhead.