linux-kernel - Re: [PATCH v2 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930094224.GA4974@sirena.org.uk>
Date:   Wed, 30 Sep 2020 10:42:24 +0100
From:   Mark Brown <broonie@...nel.org>
To:     ChiYuan Huang <u0084500@...il.com>
Cc:     Rob Herring <robh@...nel.org>, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, cy_huang <cy_huang@...htek.com>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: rtmv20: Add DT-binding document for
 Richtek RTMV20

On Wed, Sep 30, 2020 at 10:23:49AM +0800, ChiYuan Huang wrote:

>    Due to that already merged into your regulator for-next git, may I
> send the patch to fix Rob's comment?

Of course, yes please.

> And I also found one line need to be added into rtmv20 probe phase.
> Please check below.
>         /*
>          * keep in shutdown mode to minimize the current consumption
>          * and also mark regcache as dirty
>          */
> +      regcache_cache_only(priv->regmap, true);
>         regcache_mark_dirty(priv->regmap);
>         gpiod_set_value(priv->enable_gpio, 0);
> 
> Can I directly merge into one that includes Rob's comment and the
> above line to be added?

Please make it a separate patch.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)