linux-kernel - Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201001174326.GT6715@sirena.org.uk>
Date:   Thu, 1 Oct 2020 18:43:26 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     David Collins <collinsd@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

On Wed, Sep 30, 2020 at 05:07:20PM -0700, Stephen Boyd wrote:
> Quoting David Collins (2020-09-22 15:04:18)

> > This helps to disambiguate SPMI device regmaps from I2C ones
> > at /sys/kernel/debug/regmap since I2C devices use a very
> > similar naming scheme: 0-0000.

> Can regmap debugfs prepend the bus name on the node made in debugfs?
> Does it do that already?

It doesn't do that.  I have to say that given the use of dev_name() in
logging it does feel like it'd be useful to have distinct names for
grepping if we're running into collisions, IIRC the reason I went with
dev_name() was that it's a commonly used human readable handle for
diagnostic infrastrucuture so it makes it easier to follow things around.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)