linux-kernel - Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201001190733.GD23339@qmqm.qmqm.pl>
Date:   Thu, 1 Oct 2020 21:07:33 +0200
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Sameer Pujar <spujar@...dia.com>
Cc:     broonie@...nel.org, lgirdwood@...il.com, robh+dt@...nel.org,
        kuninori.morimoto.gx@...esas.com,
        pierre-louis.bossart@...ux.intel.com, perex@...ex.cz,
        tiwai@...e.com, thierry.reding@...il.com, jonathanh@...dia.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        sharadg@...dia.com, mkumard@...dia.com, viswanathl@...dia.com,
        rlokhande@...dia.com, dramesh@...dia.com, atalambedu@...dia.com,
        nwartikar@...dia.com, swarren@...dia.com, nicoleotsuka@...il.com
Subject: Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

On Thu, Oct 01, 2020 at 11:03:04PM +0530, Sameer Pujar wrote:
> Add Tegra audio machine driver which is based on generic audio graph card
> driver. It re-uses most of the common stuff from audio graph driver and
> uses the same DT binding. Required Tegra specific customizations are done
> in the driver.
[...]
> +	switch (srate) {
> +	case 11025:
> +	case 22050:
> +	case 44100:
> +	case 88200:
> +	case 176400:
> +		plla_out0_rate = chip_data->plla_out0_rates[x11_RATE];
> +		plla_rate = chip_data->plla_rates[x11_RATE];
> +		break;
> +	case 8000:
> +	case 16000:
> +	case 32000:
> +	case 48000:
> +	case 96000:
> +	case 192000:
[...]

Do you really need to enumerate the frequencies? Wouldn't just checking
srate % 11025 be enough to divide the set in two? Or just calculating
the PLLA base rate by multiplying?

Best Regards,
Michał Mirosław