linux-kernel - Re: [PATCH v3 04/18] dmaengine: idxd: add interrupt handle request support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <999e3cde-5f3e-17d8-e76f-8294c08138ab@intel.com>
Date:   Thu, 1 Oct 2020 13:16:23 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>, vkoul@...nel.org,
        megha.dey@...el.com, maz@...nel.org, bhelgaas@...gle.com,
        alex.williamson@...hat.com, jacob.jun.pan@...el.com,
        ashok.raj@...el.com, jgg@...lanox.com, yi.l.liu@...el.com,
        baolu.lu@...el.com, kevin.tian@...el.com, sanjay.k.kumar@...el.com,
        tony.luck@...el.com, jing.lin@...el.com, dan.j.williams@...el.com,
        kwankhede@...dia.com, eric.auger@...hat.com, parav@...lanox.com,
        rafael@...nel.org, netanelg@...lanox.com, shahafs@...lanox.com,
        yan.y.zhao@...ux.intel.com, pbonzini@...hat.com,
        samuel.ortiz@...el.com, mona.hossain@...el.com
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, linux-pci@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v3 04/18] dmaengine: idxd: add interrupt handle request
 support



On 9/30/2020 11:36 AM, Thomas Gleixner wrote:
> On Tue, Sep 15 2020 at 16:28, Dave Jiang wrote:
>>   
>> +#define INT_HANDLE_IMS_TABLE	0x10000
>> +int idxd_device_request_int_handle(struct idxd_device *idxd, int idx,
>> +				   int *handle, enum idxd_interrupt_type irq_type)
> 
> New lines exist for a reason and this glued together define and function
> definition is unreadable garbage.
> 
> Also is that magic bit a software flag or defined by hardware? If the
> latter then you want to move it to the other hardware defines.

Will move this to hardware register header.

> 
> Thanks,
> 
>          tglx
>   
>