linux-kernel - Re: [PATCH v2] pipe: Fix memory leaks in create_pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201001030425.GA238305@sol.localdomain>
Date:   Wed, 30 Sep 2020 20:04:25 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Qian Cai <cai@...hat.com>
Cc:     David Howells <dhowells@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files()

On Wed, Sep 30, 2020 at 10:52:55PM -0400, Qian Cai wrote:
> diff --git a/include/linux/watch_queue.h b/include/linux/watch_queue.h
> index 5e08db2adc31..20665fbe0552 100644
> --- a/include/linux/watch_queue.h
> +++ b/include/linux/watch_queue.h
> @@ -123,5 +123,9 @@ static inline void remove_watch_list(struct watch_list *wlist, u64 id)
>  #define watch_sizeof(STRUCT) (sizeof(STRUCT) << WATCH_INFO_LENGTH__SHIFT)
>  
>  #endif
> +static inline int watch_queue_init(struct pipe_inode_info *pipe)
> +{
> +	return -ENOPKG;
> +}

This needs to be conditional on !CONFIG_WATCH_QUEUE.

- Eric