linux-kernel - Re: [PATCH v2] pipe: Fix memory leaks in create_pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202010011406.KXUVyfIu-lkp@intel.com>
Date:   Thu, 1 Oct 2020 15:03:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Qian Cai <cai@...hat.com>, David Howells <dhowells@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     kbuild-all@...ts.01.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files()

Hi Qian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.9-rc7 next-20200930]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Qian-Cai/pipe-Fix-memory-leaks-in-create_pipe_files/20201001-105501
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 60e720931556fc1034d0981460164dcf02697679
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/40f946bea0970bf1dfa7a9f020e9ad7ec9f1f67d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Qian-Cai/pipe-Fix-memory-leaks-in-create_pipe_files/20201001-105501
        git checkout 40f946bea0970bf1dfa7a9f020e9ad7ec9f1f67d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from kernel/watch_queue.c:27:
>> include/linux/watch_queue.h:126:19: error: static declaration of 'watch_queue_init' follows non-static declaration
     126 | static inline int watch_queue_init(struct pipe_inode_info *pipe)
         |                   ^~~~~~~~~~~~~~~~
   include/linux/watch_queue.h:91:12: note: previous declaration of 'watch_queue_init' was here
      91 | extern int watch_queue_init(struct pipe_inode_info *);
         |            ^~~~~~~~~~~~~~~~
   kernel/watch_queue.c:648:5: error: redefinition of 'watch_queue_init'
     648 | int watch_queue_init(struct pipe_inode_info *pipe)
         |     ^~~~~~~~~~~~~~~~
   In file included from kernel/watch_queue.c:27:
   include/linux/watch_queue.h:126:19: note: previous definition of 'watch_queue_init' was here
     126 | static inline int watch_queue_init(struct pipe_inode_info *pipe)
         |                   ^~~~~~~~~~~~~~~~
--
   In file included from fs/pipe.c:27:
>> include/linux/watch_queue.h:126:19: error: static declaration of 'watch_queue_init' follows non-static declaration
     126 | static inline int watch_queue_init(struct pipe_inode_info *pipe)
         |                   ^~~~~~~~~~~~~~~~
   include/linux/watch_queue.h:91:12: note: previous declaration of 'watch_queue_init' was here
      91 | extern int watch_queue_init(struct pipe_inode_info *);
         |            ^~~~~~~~~~~~~~~~

vim +/watch_queue_init +126 include/linux/watch_queue.h

   124	
   125	#endif
 > 126	static inline int watch_queue_init(struct pipe_inode_info *pipe)
   127	{
   128		return -ENOPKG;
   129	}
   130	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (65044 bytes)