linux-kernel - Re: [PATCH v6 14/17] dt-bindings: arm: hisilicon: convert hisilicon,hip04-bootwrapper bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201001064156.GF3018@kozik-lap>
Date:   Thu, 1 Oct 2020 08:41:56 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Wei Xu <xuwei5@...ilicon.com>, Rob Herring <robh+dt@...nel.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Libin <huawei.libin@...wei.com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>
Subject: Re: [PATCH v6 14/17] dt-bindings: arm: hisilicon: convert
 hisilicon,hip04-bootwrapper bindings to json-schema

On Wed, Sep 30, 2020 at 11:17:09AM +0800, Zhen Lei wrote:
> Convert the Hisilicon Bootwrapper boot method binding to DT schema format
> using json-schema.
> 
> The property boot-method contains two groups of physical address range
> information: bootwrapper and relocation. The "uint32-array" type is not
> suitable for it, because the field "address" and "size" may occupy one or
> two cells respectively. Use "minItems: 1" and "maxItems: 2" to allow it
> can be written in "<addr size addr size>" or "<addr size>, <addr size>"
> format.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> ---
>  .../hisilicon/controller/hip04-bootwrapper.yaml    | 34 ++++++++++++++++++++++
>  .../controller/hisilicon,hip04-bootwrapper.txt     |  9 ------
>  2 files changed, 34 insertions(+), 9 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
>  delete mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hip04-bootwrapper.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
> new file mode 100644
> index 000000000000000..7378159e61df998
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/hisilicon/controller/hip04-bootwrapper.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bootwrapper boot method
> +
> +maintainers:
> +  - Wei Xu <xuwei5@...ilicon.com>
> +
> +description: Bootwrapper boot method (software protocol on SMP)
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: hisilicon,hip04-bootwrapper
> +
> +  boot-method:
> +    description: |
> +      Address and size of boot method.
> +      [0]: bootwrapper physical address
> +      [1]: bootwrapper size
> +      [2]: relocation physical address
> +      [3]: relocation size

Intead: items with each item description (bootwrapper address,
relocation address). This way also min/max Items should not be needed.

Best regards,
Krzysztof


> +    minItems: 1
> +    maxItems: 2
> +