lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Oct 2020 15:54:08 +0800 From: Coly Li <colyli@...e.de> To: linux-block@...r.kernel.org, linux-nvme@...ts.infradead.org, netdev@...r.kernel.org, open-iscsi@...glegroups.com, linux-scsi@...r.kernel.org, ceph-devel@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Coly Li <colyli@...e.de>, Jeff Layton <jlayton@...nel.org>, Ilya Dryomov <idryomov@...il.com> Subject: [PATCH v9 7/7] libceph: use sendpage_ok() in ceph_tcp_sendpage() In libceph, ceph_tcp_sendpage() does the following checks before handle the page by network layer's zero copy sendpage method, if (page_count(page) >= 1 && !PageSlab(page)) This check is exactly what sendpage_ok() does. This patch replace the open coded checks by sendpage_ok() as a code cleanup. Signed-off-by: Coly Li <colyli@...e.de> Acked-by: Jeff Layton <jlayton@...nel.org> Cc: Ilya Dryomov <idryomov@...il.com> --- net/ceph/messenger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index bdfd66ba3843..d4d7a0e52491 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c @@ -575,7 +575,7 @@ static int ceph_tcp_sendpage(struct socket *sock, struct page *page, * coalescing neighboring slab objects into a single frag which * triggers one of hardened usercopy checks. */ - if (page_count(page) >= 1 && !PageSlab(page)) + if (sendpage_ok(page)) sendpage = sock->ops->sendpage; else sendpage = sock_no_sendpage; -- 2.26.2
Powered by blists - more mailing lists