linux-kernel - Re: [PATCH v9 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0df9cb0e-7fd1-5ba0-564a-378aa0b8955f@suse.com>
Date:   Thu, 1 Oct 2020 09:10:05 -0700
From:   Lee Duncan <lduncan@...e.com>
To:     Coly Li <colyli@...e.de>, linux-block@...r.kernel.org,
        linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
        open-iscsi@...glegroups.com, linux-scsi@...r.kernel.org,
        ceph-devel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Vasily Averin <vvs@...tuozzo.com>,
        Cong Wang <amwang@...hat.com>,
        Mike Christie <michaelc@...wisc.edu>,
        Chris Leech <cleech@...hat.com>,
        Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH v9 6/7] scsi: libiscsi: use sendpage_ok() in
 iscsi_tcp_segment_map()

On 10/1/20 12:54 AM, Coly Li wrote:
> In iscsci driver, iscsi_tcp_segment_map() uses the following code to
> check whether the page should or not be handled by sendpage:
>     if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)))
> 
> The "page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)" part is to
> make sure the page can be sent to network layer's zero copy path. This
> part is exactly what sendpage_ok() does.
> 
> This patch uses  use sendpage_ok() in iscsi_tcp_segment_map() to replace
> the original open coded checks.
> 
> Signed-off-by: Coly Li <colyli@...e.de>
> Acked-by: Martin K. Petersen <martin.petersen@...cle.com>
> Cc: Vasily Averin <vvs@...tuozzo.com>
> Cc: Cong Wang <amwang@...hat.com>
> Cc: Mike Christie <michaelc@...wisc.edu>
> Cc: Lee Duncan <lduncan@...e.com>
> Cc: Chris Leech <cleech@...hat.com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Hannes Reinecke <hare@...e.de>
> ---
>  drivers/scsi/libiscsi_tcp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
> index 37e5d4e48c2f..83f14b2c8804 100644
> --- a/drivers/scsi/libiscsi_tcp.c
> +++ b/drivers/scsi/libiscsi_tcp.c
> @@ -128,7 +128,7 @@ static void iscsi_tcp_segment_map(struct iscsi_segment *segment, int recv)
>  	 * coalescing neighboring slab objects into a single frag which
>  	 * triggers one of hardened usercopy checks.
>  	 */
> -	if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)))
> +	if (!recv && sendpage_ok(sg_page(sg)))
>  		return;
>  
>  	if (recv) {
> 

Reviewed-by: Lee Duncan <lduncan@...e.com>