[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201002132721.GA12295@alpha.franken.de>
Date: Fri, 2 Oct 2020 15:27:21 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Jiaxun Yang <jiaxun.yang@...goat.com>
Cc: linux-mips@...r.kernel.org, Huacai Chen <chenhc@...ote.com>,
Serge Semin <Sergey.Semin@...kalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
WANG Xuerui <git@...0n.name>,
Paul Burton <paulburton@...nel.org>,
周琰杰 (Zhou Yanjie)
<zhouyanjie@...yeetech.com>,
afzal mohammed <afzal.mohd.ma@...il.com>,
Paul Cercueil <paul@...pouillou.net>,
Liangliang Huang <huanglllzu@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: cevt-r4k: Enable intimer for Loongson64 CPUs with
extimer
On Wed, Sep 23, 2020 at 07:02:54PM +0800, Jiaxun Yang wrote:
>
> +#ifdef CONFIG_CPU_LOONGSON64
> +static int c0_compare_int_enable(struct clock_event_device *cd)
> +{
> + if (cpu_has_extimer)
> + set_c0_config6(LOONGSON_CONF6_INTIMER);
why are you not simply do this in loognson64 board setup code and avoid
the whole cluttering of #ifdef CONFIG_CPU_LOONGSON64 over common code ?
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
Powered by blists - more mailing lists