linux-kernel - Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq18scodsa8.fsf@ca-mkp.ca.oracle.com>
Date:   Fri, 02 Oct 2020 21:15:02 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     <kartilak@...co.com>, <sebaddel@...co.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify
 the code


Jing,

> ret is always zero or an error in this code path. So the assignment to
> ret is redundant, and the code jumping to a label is unneed.
> Let's remove them to simplify the code. No functional changes.

Applied to 5.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering