linux-kernel - Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue,  6 Oct 2020 23:47:53 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>, jejb@...ux.ibm.com,
        kartilak@...co.com, sebaddel@...co.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code

On Fri, 25 Sep 2020 14:07:54 +0800, Jing Xiangfeng wrote:

> ret is always zero or an error in this code path. So the assignment to
> ret is redundant, and the code jumping to a label is unneed.
> Let's remove them to simplify the code. No functional changes.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: snic: Remove unnecessary condition
      https://git.kernel.org/mkp/scsi/c/2a7869d6c9a1

-- 
Martin K. Petersen	Oracle Linux Engineering