linux-kernel - Re: [PATCH 2/4] x86/cpu: Describe hybrid CPUs in cpuinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202010031210.n1wgHIyU-lkp@intel.com>
Date:   Sat, 3 Oct 2020 12:07:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        x86@...nel.org, Borislav Petkov <bp@...e.de>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        Tony Luck <tony.luck@...el.com>,
        Len Brown <len.brown@...el.com>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] x86/cpu: Describe hybrid CPUs in cpuinfo_x86

Hi Ricardo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/x86/core]
[also build test ERROR on tip/master driver-core/driver-core-testing linus/master v5.9-rc7 next-20201002]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ricardo-Neri/drivers-core-Introduce-CPU-type-sysfs-interface/20201003-091754
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 238c91115cd05c71447ea071624a4c9fe661f970
config: x86_64-randconfig-a012-20201002 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bcd05599d0e53977a963799d6ee4f6e0bc21331b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/ffe255e2342693ca1a8d96d052c903824595fde8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ricardo-Neri/drivers-core-Introduce-CPU-type-sysfs-interface/20201003-091754
        git checkout ffe255e2342693ca1a8d96d052c903824595fde8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
           if (cpu_has(c, X86_FEATURE_HYBRID_CPU))
                          ^
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
>> arch/x86/kernel/cpu/common.c:934:17: error: use of undeclared identifier 'X86_FEATURE_HYBRID_CPU'
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   20 errors generated.

vim +/X86_FEATURE_HYBRID_CPU +934 arch/x86/kernel/cpu/common.c

   896	
   897	void get_cpu_cap(struct cpuinfo_x86 *c)
   898	{
   899		u32 eax, ebx, ecx, edx;
   900	
   901		/* Intel-defined flags: level 0x00000001 */
   902		if (c->cpuid_level >= 0x00000001) {
   903			cpuid(0x00000001, &eax, &ebx, &ecx, &edx);
   904	
   905			c->x86_capability[CPUID_1_ECX] = ecx;
   906			c->x86_capability[CPUID_1_EDX] = edx;
   907		}
   908	
   909		/* Thermal and Power Management Leaf: level 0x00000006 (eax) */
   910		if (c->cpuid_level >= 0x00000006)
   911			c->x86_capability[CPUID_6_EAX] = cpuid_eax(0x00000006);
   912	
   913		/* Additional Intel-defined flags: level 0x00000007 */
   914		if (c->cpuid_level >= 0x00000007) {
   915			cpuid_count(0x00000007, 0, &eax, &ebx, &ecx, &edx);
   916			c->x86_capability[CPUID_7_0_EBX] = ebx;
   917			c->x86_capability[CPUID_7_ECX] = ecx;
   918			c->x86_capability[CPUID_7_EDX] = edx;
   919	
   920			/* Check valid sub-leaf index before accessing it */
   921			if (eax >= 1) {
   922				cpuid_count(0x00000007, 1, &eax, &ebx, &ecx, &edx);
   923				c->x86_capability[CPUID_7_1_EAX] = eax;
   924			}
   925		}
   926	
   927		/* Extended state features: level 0x0000000d */
   928		if (c->cpuid_level >= 0x0000000d) {
   929			cpuid_count(0x0000000d, 1, &eax, &ebx, &ecx, &edx);
   930	
   931			c->x86_capability[CPUID_D_1_EAX] = eax;
   932		}
   933	
 > 934		if (cpu_has(c, X86_FEATURE_HYBRID_CPU))
   935			c->x86_cpu_type = cpuid_eax(0x0000001a);
   936	
   937		/* AMD-defined flags: level 0x80000001 */
   938		eax = cpuid_eax(0x80000000);
   939		c->extended_cpuid_level = eax;
   940	
   941		if ((eax & 0xffff0000) == 0x80000000) {
   942			if (eax >= 0x80000001) {
   943				cpuid(0x80000001, &eax, &ebx, &ecx, &edx);
   944	
   945				c->x86_capability[CPUID_8000_0001_ECX] = ecx;
   946				c->x86_capability[CPUID_8000_0001_EDX] = edx;
   947			}
   948		}
   949	
   950		if (c->extended_cpuid_level >= 0x80000007) {
   951			cpuid(0x80000007, &eax, &ebx, &ecx, &edx);
   952	
   953			c->x86_capability[CPUID_8000_0007_EBX] = ebx;
   954			c->x86_power = edx;
   955		}
   956	
   957		if (c->extended_cpuid_level >= 0x80000008) {
   958			cpuid(0x80000008, &eax, &ebx, &ecx, &edx);
   959			c->x86_capability[CPUID_8000_0008_EBX] = ebx;
   960		}
   961	
   962		if (c->extended_cpuid_level >= 0x8000000a)
   963			c->x86_capability[CPUID_8000_000A_EDX] = cpuid_edx(0x8000000a);
   964	
   965		init_scattered_cpuid_features(c);
   966		init_speculation_control(c);
   967	
   968		/*
   969		 * Clear/Set all flags overridden by options, after probe.
   970		 * This needs to happen each time we re-probe, which may happen
   971		 * several times during CPU initialization.
   972		 */
   973		apply_forced_caps(c);
   974	}
   975	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34752 bytes)