linux-kernel - Re: [PATCH v2 4/5] media: mt9p031: Make pixel clock polarity configurable by DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1121fe39-2965-0782-85cc-2dcb9996b978@phytec.de>
Date:   Mon, 5 Oct 2020 10:52:01 +0200
From:   Stefan Riedmüller <s.riedmueller@...tec.de>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Christian Hemp <c.hemp@...tec.de>
Subject: Re: [PATCH v2 4/5] media: mt9p031: Make pixel clock polarity
 configurable by DT

Hi Sakari,

On 01.10.20 18:11, Sakari Ailus wrote:
> On Thu, Oct 01, 2020 at 07:10:31PM +0300, Sakari Ailus wrote:
>>> @@ -1079,6 +1094,9 @@ mt9p031_get_pdata(struct i2c_client *client)
>>>   	of_property_read_u32(np, "input-clock-frequency", &pdata->ext_freq);
>>>   	of_property_read_u32(np, "pixel-clock-frequency", &pdata->target_freq);
>>>   
>>> +	pdata->pixclk_pol = !!(endpoint.bus.parallel.flags &
>>> +			       V4L2_MBUS_PCLK_SAMPLE_RISING);
>>
>> Could you document this in DT bindings? And the default, too.
> 
> Please make it a separate patch.

Sure, I'll send a separate patch for the DT bindings.

Regards,
Stefan

>