linux-kernel - Re: [PATCH RFC] checkpatch: add new warnings to author signoff checks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 5 Oct 2020 14:22:33 +0530
From:   Dwaipayan Ray <dwaipayanray1@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] checkpatch: add new warnings to author signoff checks.

On Mon, Oct 5, 2020 at 2:13 PM Joe Perches <joe@...ches.com> wrote:
>
> On Mon, 2020-10-05 at 13:50 +0530, Dwaipayan Ray wrote:
> > On Mon, Oct 5, 2020 at 1:35 PM Joe Perches <joe@...ches.com> wrote:
> > > On Mon, 2020-10-05 at 13:10 +0530, Dwaipayan Ray wrote:
> > > > On Mon, Oct 5, 2020 at 12:48 PM Joe Perches <joe@...ches.com> wrote:
> > > > > On Mon, 2020-10-05 at 12:18 +0530, Dwaipayan Ray wrote:
> > > > > > The author signed-off-by checks are currently very vague.
> > > > > > Cases like same name or same address are not handled separately.
> > > []
> > > > > And for mismatches, it's really not known that
> > > > > it should be one way or the or the other is it?
> > > > >
> > > >
> > > > I think that's true. But since the mail in the
> > > > From: part is the one which with others are being
> > > > compared, I think maybe it should have the higher
> > > > priority, and be treated as the expected one.
> > >
> > > I rather expect it to be the other way around.
> > >
> > > The Signed-off-by: line should be authoritative
> > > as that is what is put in the commit log.
> > >
> > >
> > Yes that makes sense. So is it just better to point at
> > the difference?
> > Like:
> > Author email in From: (something) differs from
> > Signed-off-by: (something2).
>
> I think so yes.
>
> That's what I suggested when I replied to you
> with your first attempt.
>
> https://lore.kernel.org/lkml/7958ded756c895ca614ba900aae7b830a992475e.camel@perches.com/
>
>                         WARN("NO_AUTHOR_SIGN_OFF",
>                              "From:/SoB: email address mismatch: 'From: $author' != 'Signed-off-by: $authorsignoff'\n");
>
> And please keep replies on list.
>
Yes sure, I missed to cc the list.

I will fix the issues and get back to you with a new patch.

Thanks,
Dwaipayan.