linux-kernel - [PATCH] hwmon: (pmbus/max34440) Fix/add missing break statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Oct 2020 14:50:41 +0300
From:   Alexandru Ardelean <alexandru.ardelean@...log.com>
To:     <linux-hwmon@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <linux@...ck-us.net>, <jdelvare@...e.com>, <foremans@...gle.com>,
        Alexandru Ardelean <alexandru.ardelean@...log.com>
Subject: [PATCH] hwmon: (pmbus/max34440) Fix/add missing break statements

This one was caught by the compiler.
Adds missing break statements, which look omitted by accident.

Fixes: 599a5ac5f96c ("hwmon: (pmbus/max34440) Fix/add missing break statements")
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
---

Maybe the lkp bot also reported this [by now].
I just bumped into this now, trying to work on another driver.
Now whether this gets applied, or a V2 is created, is not important from my
side.

This is a heads-up [from my side].

 drivers/hwmon/pmbus/max34440.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/hwmon/pmbus/max34440.c b/drivers/hwmon/pmbus/max34440.c
index bdea52996580..f4cb196aaaf3 100644
--- a/drivers/hwmon/pmbus/max34440.c
+++ b/drivers/hwmon/pmbus/max34440.c
@@ -61,9 +61,11 @@ static int max34440_read_word_data(struct i2c_client *client, int page,
 	case PMBUS_IOUT_OC_FAULT_LIMIT:
 		ret = pmbus_read_word_data(client, page, phase,
 					   MAX34440_IOUT_OC_FAULT_LIMIT);
+		break;
 	case PMBUS_IOUT_OC_WARN_LIMIT:
 		ret = pmbus_read_word_data(client, page, phase,
 					   MAX34440_IOUT_OC_WARN_LIMIT);
+		break;
 	case PMBUS_VIRT_READ_VOUT_MIN:
 		ret = pmbus_read_word_data(client, page, phase,
 					   MAX34440_MFR_VOUT_MIN);
@@ -133,9 +135,11 @@ static int max34440_write_word_data(struct i2c_client *client, int page,
 	case PMBUS_IOUT_OC_FAULT_LIMIT:
 		ret = pmbus_write_word_data(client, page, MAX34440_IOUT_OC_FAULT_LIMIT,
 					    word);
+		break;
 	case PMBUS_IOUT_OC_WARN_LIMIT:
 		ret = pmbus_write_word_data(client, page, MAX34440_IOUT_OC_WARN_LIMIT,
 					    word);
+		break;
 	case PMBUS_VIRT_RESET_POUT_HISTORY:
 		ret = pmbus_write_word_data(client, page,
 					    MAX34446_MFR_POUT_PEAK, 0);
-- 
2.25.1