linux-kernel - Re: [PATCH] hwmon: (pmbus/max34440) Fix/add missing break statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40cc33b8-1dcf-898d-42f1-53b4404a80b9@roeck-us.net>
Date:   Mon, 5 Oct 2020 08:09:02 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     jdelvare@...e.com, foremans@...gle.com
Subject: Re: [PATCH] hwmon: (pmbus/max34440) Fix/add missing break statements

On 10/5/20 4:50 AM, Alexandru Ardelean wrote:
> This one was caught by the compiler.
> Adds missing break statements, which look omitted by accident.
> 
Most definitely.

> Fixes: 599a5ac5f96c ("hwmon: (pmbus/max34440) Fix/add missing break statements")

This should point to the culprit.

> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> ---
> 
> Maybe the lkp bot also reported this [by now].
> I just bumped into this now, trying to work on another driver.
> Now whether this gets applied, or a V2 is created, is not important from my
> side.
> 
Thanks, folded into the original patch.

Guenter

> This is a heads-up [from my side].
> 
>  drivers/hwmon/pmbus/max34440.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/hwmon/pmbus/max34440.c b/drivers/hwmon/pmbus/max34440.c
> index bdea52996580..f4cb196aaaf3 100644
> --- a/drivers/hwmon/pmbus/max34440.c
> +++ b/drivers/hwmon/pmbus/max34440.c
> @@ -61,9 +61,11 @@ static int max34440_read_word_data(struct i2c_client *client, int page,
>  	case PMBUS_IOUT_OC_FAULT_LIMIT:
>  		ret = pmbus_read_word_data(client, page, phase,
>  					   MAX34440_IOUT_OC_FAULT_LIMIT);
> +		break;
>  	case PMBUS_IOUT_OC_WARN_LIMIT:
>  		ret = pmbus_read_word_data(client, page, phase,
>  					   MAX34440_IOUT_OC_WARN_LIMIT);
> +		break;
>  	case PMBUS_VIRT_READ_VOUT_MIN:
>  		ret = pmbus_read_word_data(client, page, phase,
>  					   MAX34440_MFR_VOUT_MIN);
> @@ -133,9 +135,11 @@ static int max34440_write_word_data(struct i2c_client *client, int page,
>  	case PMBUS_IOUT_OC_FAULT_LIMIT:
>  		ret = pmbus_write_word_data(client, page, MAX34440_IOUT_OC_FAULT_LIMIT,
>  					    word);
> +		break;
>  	case PMBUS_IOUT_OC_WARN_LIMIT:
>  		ret = pmbus_write_word_data(client, page, MAX34440_IOUT_OC_WARN_LIMIT,
>  					    word);
> +		break;
>  	case PMBUS_VIRT_RESET_POUT_HISTORY:
>  		ret = pmbus_write_word_data(client, page,
>  					    MAX34446_MFR_POUT_PEAK, 0);
>