linux-kernel - Re: [PATCH] leds: lm3697: Fix out-of-bound access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MItOR9Z--3-2@tutanota.com>
Date:   Mon, 5 Oct 2020 17:35:38 +0200 (CEST)
From:   ultracoolguy@...anota.com
To:     Dan Murphy <dmurphy@...com>
Cc:     Marek Behun <kabel@...ckhole.sk>, Pavel <pavel@....cz>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux Leds <linux-leds@...r.kernel.org>
Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access

Well, the major benefit I see is that it makes the driver slightly more readable. However I'm fine with whatever you guys decide.

I'll attach the patch with the struct renaming removed just in case.



Oct 5, 2020, 14:41 by dmurphy@...com:

> Gabriel
>
> On 10/5/20 9:38 AM, ultracoolguy@...anota.com wrote:
>
>> I understand. So I should leave it like it was and do the rename in another patch?
>>
>
> You should do the fix in one patch and leave the structure name alone.
>
> The structure naming if fine and has no benefit and actually will make it more difficult for others to backport future fixes.
>
> Unless Pavel finds benefit in accepting the structure rename.
>
> Dan
>


View attachment "0001-leds-lm3697-Fix-out-of-bound-access.patch" of type "text/x-patch" (2181 bytes)