[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201006071938.GA5503@kroah.com>
Date: Tue, 6 Oct 2020 09:19:38 +0200
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: "Harley A.W. Lorenzo" <hl1998@...tonmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-safety@...ts.elisa.tech" <linux-safety@...ts.elisa.tech>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"stern@...land.harvard.edu" <stern@...land.harvard.edu>
Subject: Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference
On Mon, Oct 05, 2020 at 11:19:02PM +0000, Harley A.W. Lorenzo wrote:
> On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:
>
> > find_tt() can return NULL or the error value in ERR_PTR() and
> > dereferencing the return value without checking for the error can
> > lead to a possible dereference of NULL pointer or ERR_PTR().
>
> Looks fine to me. There is in fact no checks of the return value
> before a dereference here, and this solves that.
>
> Reviewed-by: Harley A.W. Lorenzo <hl1998@...tonmail.com
Nit, in the future, you need the trailing '>' there.
thanks,
greg k-h
Powered by blists - more mailing lists