linux-kernel - Re: [PATCH] leds: lm3697: Fix out-of-bound access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201006093356.6d25b280@blackhole.sk>
Date:   Tue, 6 Oct 2020 09:33:56 +0200
From:   Marek Behun <kabel@...ckhole.sk>
To:     Pavel Machek <pavel@....cz>
Cc:     ultracoolguy@...anota.com, Alexander Dahl <post@...pocky.de>,
        Dmurphy <dmurphy@...com>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux Leds <linux-leds@...r.kernel.org>
Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access

By the way I just realized that the DT binding in this driver seems
incorrect to me.

The controller logically supports 3 LED strings, each having
configurable control bank.

But the DT binding supports 2 DT nodes, one for each control bank
(identified by the `reg` property) and then `led-sources` says which
string should be controlled by given bank.

But taking in mind that DT should describe how devices are connected to
each other, I think the child nodes in the binding should instead
describe the 3 supported LED strings...

Marek