linux-kernel - RE: [PATCH v3 1/2] exfat: add exfat_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000b01d69bba$08047320$180d5960$@samsung.com>
Date:   Tue, 6 Oct 2020 17:23:55 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Tetsuhiro Kohada'" <kohada.t2@...il.com>
Cc:     <kohada.tetsuhiro@...mitsubishielectric.co.jp>,
        <mori.takahiro@...mitsubishielectric.co.jp>,
        "'Sungjong Seo'" <sj1557.seo@...sung.com>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 1/2] exfat: add exfat_update_inode()

> @@ -1352,19 +1340,13 @@ static int exfat_rename(struct inode *old_dir, struct dentry *old_dentry,
>  	new_dir->i_ctime = new_dir->i_mtime = new_dir->i_atime =
>  		EXFAT_I(new_dir)->i_crtime = current_time(new_dir);
>  	exfat_truncate_atime(&new_dir->i_atime);
> -	if (IS_DIRSYNC(new_dir))
> -		exfat_sync_inode(new_dir);
> -	else
> -		mark_inode_dirty(new_dir);
> +	exfat_update_inode(new_dir);
> 
>  	i_pos = ((loff_t)EXFAT_I(old_inode)->dir.dir << 32) |
>  		(EXFAT_I(old_inode)->entry & 0xffffffff);
>  	exfat_unhash_inode(old_inode);
>  	exfat_hash_inode(old_inode, i_pos);
> -	if (IS_DIRSYNC(new_dir))
> -		exfat_sync_inode(old_inode);
> -	else
> -		mark_inode_dirty(old_inode);
> +	exfat_update_inode(old_inode);
This is checking if old_inode is IS_DIRSYNC, not new_dir.
Is there any reason ?