linux-kernel - Re: [PATCH 0/4] dt-bindings: additional/unevaluatedProperties clean-ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d04c47dd-6e37-a7ac-f3c4-d6e6c308dbcd@linaro.org>
Date:   Tue, 6 Oct 2020 09:25:06 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Albert Ou <aou@...s.berkeley.edu>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Andrew Lunn <andrew@...n.ch>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "David S. Miller" <davem@...emloft.net>, dmaengine@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        dri-devel@...ts.freedesktop.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Jason Cooper <jason@...edaemon.net>,
        Jens Axboe <axboe@...nel.dk>,
        Jonathan Cameron <jic23@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Marc Zyngier <maz@...nel.org>, Mark Brown <broonie@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Pavel Machek <pavel@....cz>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Richard Weinberger <richard@....at>,
        Sam Ravnborg <sam@...nborg.org>,
        Sebastian Reichel <sre@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Viresh Kumar <vireshk@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Zhang Rui <rui.zhang@...el.com>,
        linux-arm-kernel@...ts.infradead.org, linux-can@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-ide@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-input@...r.kernel.org, linux-leds@...r.kernel.org,
        linux-media@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-mtd@...ts.infradead.org,
        linux-pci@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-pwm@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-rtc@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 0/4] dt-bindings: additional/unevaluatedProperties
 clean-ups



On 05/10/2020 19:38, Rob Herring wrote:
> The default behavior for json-schema is any unknown property is allowed.
> T
> 
> hat is generally not the behavior we want for DT. In order to disallow
> extra properties, schemas need to define 'additionalProperties: false'
> typically. Ideally, we'd just add that automatically with the tools, but
> there are some exceptions so only making things explicit everywhere
> really works. Missing 'additionalProperties' or 'unevaluatedProperties'
> has been a constant source of review comments, so a meta-schema check is
> really needed here.
> 
>   Documentation/devicetree/bindings/nvmem/nvmem.yaml     |  2 ++
>   .../devicetree/bindings/nvmem/qcom,qfprom.yaml         |  2 ++

for nvmem parts,

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>


thanks,
--srini