linux-kernel - Re: [PATCH] cpufreq: schedutil: Simplify sugov_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201007051128.odqiwuex3vqwxumo@vireshk-i7>
Date:   Wed, 7 Oct 2020 10:41:28 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: schedutil: Simplify sugov_fast_switch()

On 06-10-20, 14:01, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Drop a redundant local variable definition from sugov_fast_switch()
> and rearrange the code in there to avoid the redundant logical
> negation.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> 
> The code reads a bit easier after this change IMV.
> 
> linux-next material.
> 
> ---
>  kernel/sched/cpufreq_schedutil.c |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> Index: linux-pm/kernel/sched/cpufreq_schedutil.c
> ===================================================================
> --- linux-pm.orig/kernel/sched/cpufreq_schedutil.c
> +++ linux-pm/kernel/sched/cpufreq_schedutil.c
> @@ -114,12 +114,8 @@ static bool sugov_update_next_freq(struc
>  static void sugov_fast_switch(struct sugov_policy *sg_policy, u64 time,
>  			      unsigned int next_freq)
>  {
> -	struct cpufreq_policy *policy = sg_policy->policy;
> -
> -	if (!sugov_update_next_freq(sg_policy, time, next_freq))
> -		return;
> -
> -	cpufreq_driver_fast_switch(policy, next_freq);
> +	if (sugov_update_next_freq(sg_policy, time, next_freq))
> +		cpufreq_driver_fast_switch(sg_policy->policy, next_freq);
>  }
>  
>  static void sugov_deferred_update(struct sugov_policy *sg_policy, u64 time,

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh