linux-kernel - Re: linux-next: Tree for Oct 6 (drivers/misc/hisi_hikey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLU672fOHudfvZWDEoO=fHYt79isz35e9EaJAsvTCg5How@mail.gmail.com>
Date:   Tue, 6 Oct 2020 17:10:15 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Yu Chen <chenyu56@...wei.com>
Subject: Re: linux-next: Tree for Oct 6 (drivers/misc/hisi_hikey_usb.c)

On Tue, Oct 6, 2020 at 12:29 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 10/6/20 5:12 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20201002:
> >
>
> on x86_64:
> CONFIG_USB_ROLE_SWITCH=m
> and HISI_HIKEY_USB=y.
>
> ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove':
> hisi_hikey_usb.c:(.text+0x61): undefined reference to `usb_role_switch_unregister'
> ld: hisi_hikey_usb.c:(.text+0xa4): undefined reference to `usb_role_switch_put'
> ld: drivers/misc/hisi_hikey_usb.o: in function `hub_usb_role_switch_set':
> hisi_hikey_usb.c:(.text+0xd3): undefined reference to `usb_role_switch_get_drvdata'
> ld: drivers/misc/hisi_hikey_usb.o: in function `relay_set_role_switch':
> hisi_hikey_usb.c:(.text+0x54d): undefined reference to `usb_role_switch_set_role'
> ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_probe':
> hisi_hikey_usb.c:(.text+0x8a5): undefined reference to `usb_role_switch_get'
> ld: hisi_hikey_usb.c:(.text+0xa08): undefined reference to `usb_role_switch_register'
> ld: hisi_hikey_usb.c:(.text+0xa6e): undefined reference to `usb_role_switch_put'
>
>
> Full randconfig file is attached.
>

Adding Mauro to the thread, as he's the one submitting that patch upstream.

Looks like we need to tweak the kconfig so it depends on CONFIG_USB_ROLE_SWITCH.

thanks
-john