linux-kernel - Re: [PATCH v2] kernel/sysctl.c: drop unneeded assignment in proc_do_large

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202010071144.FA87F25D5D@keescook>
Date:   Wed, 7 Oct 2020 11:44:06 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Luis Chamberlain <mcgrof@...nel.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        linux-kernel@...r.kernel.org, linux-safety@...ts.elisa.tech,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2] kernel/sysctl.c: drop unneeded assignment in
 proc_do_large_bitmap()

On Wed, Oct 07, 2020 at 04:19:04PM +0100, Sudip Mukherjee wrote:
> The variable 'first' is assigned 0 inside the while loop in the if block
> but it is not used in the if block and is only used in the else block.
> So, remove the unneeded assignment and move the variable in the else block.
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook