linux-kernel - RE: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted Firmware Service call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB2876DAA8003FD42C814A16FBB80B0@DM6PR11MB2876.namprd11.prod.outlook.com>
Date:   Thu, 8 Oct 2020 10:39:37 +0000
From:   "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@...el.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "Hunter, Adrian" <adrian.hunter@...el.com>,
        Michal Simek <michal.simek@...inx.com>,
        "Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Raja Subramanian, Lakshmi Bai" 
        <lakshmi.bai.raja.subramanian@...el.com>,
        "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@...el.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: RE: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted
 Firmware Service call

Hi Andy,

Thanks for the feedback.

>-----Original Message-----
>From: Andy Shevchenko <andy.shevchenko@...il.com>
>Sent: Thursday, October 8, 2020 4:46 PM
>To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>
>Cc: Hunter, Adrian <adrian.hunter@...el.com>; Michal Simek
><michal.simek@...inx.com>; Shevchenko, Andriy
><andriy.shevchenko@...el.com>; Ulf Hansson <ulf.hansson@...aro.org>; linux-
>mmc <linux-mmc@...r.kernel.org>; linux-arm Mailing List <linux-arm-
>kernel@...ts.infradead.org>; Linux Kernel Mailing List <linux-
>kernel@...r.kernel.org>; Raja Subramanian, Lakshmi Bai
><lakshmi.bai.raja.subramanian@...el.com>; Wan Mohamad, Wan Ahmad Zainie
><wan.ahmad.zainie.wan.mohamad@...el.com>; Arnd Bergmann
><arnd@...db.de>
>Subject: Re: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted
>Firmware Service call
>
>On Thu, Oct 8, 2020 at 5:48 AM <muhammad.husaini.zulkifli@...el.com> wrote:
>>
>> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>
>>
>> Add header file to handle API function for device driver to
>> communicate with Arm Trusted Firmware.
>
>Arm -> ARM ?
I will rename based on Sudeep's mentioned in latest thread
>
>...
>
>>  .../linux/firmware/intel/keembay_firmware.h   | 47 +++++++++++++++++++
>
>Please, drop dup of 'firmware' in the filename.
Noted. Will change to keembay.h
>
>...
>
>> +/*
>> + *  Intel Keembay SOC Firmware API Layer
>> + *
>
>> + *  Copyright (C) 2020-2021, Intel Corporation
>
>Hello from the future?
>
Will edit to Copyright (C) 2020, Intel Corporation
>> + *
>> + *  Muhammad Husaini Zulkifli <Muhammad.Husaini.Zulkifli@...el.com>
>
>Author: ...
>
>> + */
>
>...
>
>> +/*
>> + * This file defines API function that can be called by device driver
>> +in order to
>
>an API
>by a device
Noted 😊
>
>> + * communicate with Arm Trusted Firmware.
>
>Arm -> ARM ?
I will rename based on Sudeep's mentioned in latest thread
>
>> + */
>
>--
>With Best Regards,
>Andy Shevchenko