linux-kernel - Re: [PATCH] misc: Kconfig: add a new dependency for HISI_HIKEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2992583d-1954-b329-86bc-c61aa35040dd@infradead.org>
Date:   Wed, 7 Oct 2020 19:52:56 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linuxarm@...wei.com, mauro.chehab@...wei.com,
        John Stultz <john.stultz@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: Kconfig: add a new dependency for HISI_HIKEY_USB

On 10/7/20 7:18 PM, Nathan Chancellor wrote:
> On Wed, Oct 07, 2020 at 07:09:54AM +0200, Mauro Carvalho Chehab wrote:
>> As warned by Randy:
>>
>> 	on x86_64:
>> 	CONFIG_USB_ROLE_SWITCH=m
>> 	and HISI_HIKEY_USB=y.
>>
>> 	ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove':
>> 	hisi_hikey_usb.c:(.text+0x61): undefined reference to `usb_role_switch_unregister'
>> 	ld: hisi_hikey_usb.c:(.text+0xa4): undefined reference to `usb_role_switch_put'
>> 	ld: drivers/misc/hisi_hikey_usb.o: in function `hub_usb_role_switch_set':
>> 	hisi_hikey_usb.c:(.text+0xd3): undefined reference to `usb_role_switch_get_drvdata'
>> 	ld: drivers/misc/hisi_hikey_usb.o: in function `relay_set_role_switch':
>> 	hisi_hikey_usb.c:(.text+0x54d): undefined reference to `usb_role_switch_set_role'
>> 	ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_probe':
>> 	hisi_hikey_usb.c:(.text+0x8a5): undefined reference to `usb_role_switch_get'
>> 	ld: hisi_hikey_usb.c:(.text+0xa08): undefined reference to `usb_role_switch_register'
>> 	ld: hisi_hikey_usb.c:(.text+0xa6e): undefined reference to `usb_role_switch_put'
>>
>> Make it dependent on CONFIG_USB_ROLE_SWITCH.
>>
>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
>> ---
>>  drivers/misc/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
>> index e19e1dcceb41..7cee2b72c09e 100644
>> --- a/drivers/misc/Kconfig
>> +++ b/drivers/misc/Kconfig
>> @@ -459,6 +459,7 @@ config PVPANIC
>>  config HISI_HIKEY_USB
>>  	tristate "USB GPIO Hub on HiSilicon Hikey 960/970 Platform"
>>  	depends on (OF && GPIOLIB) || COMPILE_TEST
>> +	depends on CONFIG_USB_ROLE_SWITCH
> 
> Shouldn't this be
> 
> depends on USB_ROLE_SWITCH

Obviously. Thanks for catching that.

> ? Now it will never be selectable.
>
>>  	help
>>  	  If you say yes here this adds support for the on-board USB GPIO hub
>>  	  found on HiKey 960/970 boards, which is necessary to support
>> -- 
>> 2.26.2
>>
> 
> Cheers,
> Nathan
> 


-- 
~Randy