linux-kernel - Re: [v5 01/12] struct device: Add function callback durable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1tuv41m8u.fsf@ca-mkp.ca.oracle.com>
Date:   Thu, 08 Oct 2020 16:49:17 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Tony Asleson <tasleson@...hat.com>,
        Christoph Hellwig <hch@...radead.org>,
        linux-scsi@...r.kernel.org, linux-block@...r.kernel.org,
        linux-ide@...r.kernel.org, Hannes Reinecke <hare@...e.de>,
        pmladek@...e.com, David Lehman <dlehman@...hat.com>,
        sergey.senozhatsky@...il.com, jbaron@...mai.com,
        James.Bottomley@...senpartnership.com,
        linux-kernel@...r.kernel.org, rafael@...nel.org,
        martin.petersen@...cle.com, kbusch@...nel.org, axboe@...com,
        sagi@...mberg.me, akpm@...ux-foundation.org, orson.zhai@...soc.com,
        viro@...iv.linux.org.uk
Subject: Re: [v5 01/12] struct device: Add function callback durable_name


Greg,

>> > What text is changing? The format of of the prefix of dev_*() is well
>> > known and has been stable for 15+ years now, right?  What is difficult
>> > in parsing it?
>> 
>> Many of the storage layer messages are using printk, not dev_printk.
>
> Ok, then stop right there.  Fix that up.  Don't try to route around the
> standard way of displaying log messages by creating a totally different
> way of doing things.

Couldn't agree more!

-- 
Martin K. Petersen	Oracle Linux Engineering