[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <HK0PR06MB3380804F3330D4D34E01CC0DF2080@HK0PR06MB3380.apcprd06.prod.outlook.com>
Date: Fri, 9 Oct 2020 05:59:19 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Greg KH <greg@...ah.com>, Joel Stanley <joel@....id.au>
CC: Andrew Jeffery <andrew@...id.au>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
BMC-SW <BMC-SW@...eedtech.com>,
Alan Stern <stern@...land.harvard.edu>
Subject: RE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
> -----Original Message-----
> From: Greg KH <greg@...ah.com>
> Sent: Friday, October 9, 2020 1:47 PM
> To: Joel Stanley <joel@....id.au>
> Cc: Ryan Chen <ryan_chen@...eedtech.com>; Andrew Jeffery
> <andrew@...id.au>; Linux ARM <linux-arm-kernel@...ts.infradead.org>;
> linux-aspeed <linux-aspeed@...ts.ozlabs.org>; Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org>; linux-usb@...r.kernel.org; BMC-SW
> <BMC-SW@...eedtech.com>; Alan Stern <stern@...land.harvard.edu>
> Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
>
> On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote:
> > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@...ah.com> wrote:
> > >
> > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > > > v2:
> > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > > > v1:
> > > > -Enable UHCI driver in aspeed_g5_defconfig.
> > > >
> > > > Signed-off-by: Ryan Chen <ryan_chen@...eedtech.com>
> > >
> > > Why do you need this in a defconfig?
> >
> > I would prefer configurations that are being used to be present in the
> > defconfig so we can test it. I think this is a sensible change.
>
> Then it needs to be described in the changelog, otherwise we have no idea
> why this is happening :)
>
Ok, will send new version describe it.
Powered by blists - more mailing lists