linux-kernel - RE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK0PR06MB33809BDA9FD8956CDBE78061F2080@HK0PR06MB3380.apcprd06.prod.outlook.com>
Date:   Fri, 9 Oct 2020 06:01:06 +0000
From:   Ryan Chen <ryan_chen@...eedtech.com>
To:     Joel Stanley <joel@....id.au>, Greg KH <greg@...ah.com>
CC:     Andrew Jeffery <andrew@...id.au>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        BMC-SW <BMC-SW@...eedtech.com>,
        Alan Stern <stern@...land.harvard.edu>
Subject: RE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

> -----Original Message-----
> From: Joel Stanley <joel@....id.au>
> Sent: Friday, October 9, 2020 12:55 PM
> To: Greg KH <greg@...ah.com>
> Cc: Ryan Chen <ryan_chen@...eedtech.com>; Andrew Jeffery
> <andrew@...id.au>; Linux ARM <linux-arm-kernel@...ts.infradead.org>;
> linux-aspeed <linux-aspeed@...ts.ozlabs.org>; Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org>; linux-usb@...r.kernel.org; BMC-SW
> <BMC-SW@...eedtech.com>; Alan Stern <stern@...land.harvard.edu>
> Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
> 
> On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@...ah.com> wrote:
> >
> > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > > v2:
> > >  -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > > v1:
> > >  -Enable UHCI driver in aspeed_g5_defconfig.
> > >
> > > Signed-off-by: Ryan Chen <ryan_chen@...eedtech.com>
> >
> > Why do you need this in a defconfig?
> 
> I would prefer configurations that are being used to be present in the defconfig
> so we can test it. I think this is a sensible change.
> 
> Ryan, I gave you my Reviewed-by for the last version of the patch. As you did
> not change the contents of this patch it is fine for you to leave my Reviewed-by
> on it.

Joel, thanks the review, so I need add Reviewed-by at each patch if someone have reviewed the previous patch,
am I right?