linux-kernel - Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201009115946.fl4lvkg5yk7f43pz@calculus>
Date:   Fri, 9 Oct 2020 06:59:46 -0500
From:   Nishanth Menon <nm@...com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>
CC:     <t-kristo@...com>, <ssantosh@...nel.org>, <lokeshvutla@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <grygorii.strashko@...com>
Subject: Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for
 allocation in RING mode

On 10:43-20201009, Peter Ujfalusi wrote:
> Nishanth,
> 
> On 09/10/2020 6.02, Nishanth Menon wrote:
> > On 14:52-20201008, Peter Ujfalusi wrote:
> >> -	ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev,
> >> +	ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev,
> >>  					ring->size * (4 << ring->elm_size),
> >>  					&ring->ring_mem_dma, GFP_KERNEL);
> > 
> > Any chance of getting a cleanup of the file for 5.11? I know this series
> > has'nt introduced this warning or set of warnings, but I am starting to
> > get concerned that we are carrying over too much of a debt now?
> > 
> > https://pastebin.ubuntu.com/p/tT2kPDsCWD/
> 
> Right, you know that git blame points the finger at you on ti_sci.c errors?
> 
> Never the less, I have run the tool locally on my linux-next-wip with
> these patches:
> https://pastebin.ubuntu.com/p/myJwjvKYw8/
> 
> and I don't see the noise you see.


Hmm.. Looks like gcc9/10 make W=2 does generate those warnings with
container_of .. I will investigate it later today.. just checking to see
if it is just me seeing this..

Yes, I introduced the container_of() usage, which is pretty standard
usage in other subsystems as well, but lots of checks have gotten
stricter and catches new issues since I introduced things in 2016..
Time to get the new issues (if valid) fixed up.

> 
> > Checkpatch does point this:
> > 
> > --- /tmp/kernel-patch-verify.25812/ptest_check-start	2020-10-08
> > 19:33:31.025898581 +0000
> > +++ /tmp/kernel-patch-verify.25812/ptest_check-end	2020-10-08
> > 19:33:31.593893830 +0000
> > @@ -0,0 +1,6 @@
> > +CHECK: Alignment should match open parenthesis
> > +#84: FILE: drivers/soc/ti/k3-ringacc.c:657:
> > ++	ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev,
> > + 					ring->size * (4 << ring->elm_size),
> 
> Yes, that's correct. Readability VS very long lines


checkpatch limit in linux kernel is now 100 chars (I know, it is
hard to update .vimrc etc.. to the new norm..)but, anyways.. will
be good not to see such warnings esp when you are touching the same
lines.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D