linux-kernel - Re: [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Oct 2020 16:42:36 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Felipe Balbi <balbi@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Manu Gautam <mgautam@...eaurora.org>,
        Roger Quadros <rogerq@...com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless"
 maximum-speed property value

On Sun, Oct 11, 2020 at 01:41:05AM +0300, Serge Semin wrote:
> It appears that the "maximum-speed" property can also accept the
> "wireless" value. Add it to the enumeration of the possible property
> values then.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> ---
>  Documentation/devicetree/bindings/usb/usb-hcd.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-hcd.yaml b/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> index 815de24127db..e1a82a2b3295 100644
> --- a/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> @@ -28,7 +28,7 @@ properties:
>       isn't passed via DT, USB controllers should default to their maximum HW
>       capability.
>     $ref: /schemas/types.yaml#/definitions/string
> -   enum: ["low-speed", "full-speed", "high-speed", "super-speed",
> +   enum: ["low-speed", "full-speed", "high-speed", "wireless", "super-speed",
>            "super-speed-plus"]

Are you sure?  wireless usb has been removed from the kernel, where do
you see a user of this?  If it's still in there, we need to just drop
it.

thanks,

greg k-h