linux-kernel - Re: [PATCH v2] mm: memcontrol: eliminate redundant check in __mem_cgroup_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201012135852.GB188876@cmpxchg.org>
Date:   Mon, 12 Oct 2020 09:58:52 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, mhocko@...nel.org,
        vdavydov.dev@...il.com, cgroups@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: memcontrol: eliminate redundant check in
 __mem_cgroup_insert_exceeded()

On Mon, Oct 12, 2020 at 09:16:07AM -0400, Miaohe Lin wrote:
> The mz->usage_in_excess >= mz_node->usage_in_excess check is exactly the
> else case of mz->usage_in_excess < mz_node->usage_in_excess. So we could
> replace else if (mz->usage_in_excess >= mz_node->usage_in_excess) with else
> equally. Also drop the comment which doesn't really explain much.
> 
> Acked-by: Michal Hocko <mhocko@...e.com>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Looks good to me.

Acked-by: Johannes Weiner <hannes@...xchg.org>