linux-kernel - Re: [Cocci] [PATCH v4 2/3] scripts: coccicheck: Change default condition for parallelism

Open Source and information security mailing list archives

Message-ID: <alpine.DEB.2.22.394.2010121038040.2901@hadrien>
Date:   Mon, 12 Oct 2020 10:38:14 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Sumera Priyadarsini <sylphrenadin@...il.com>
cc:     Julia.Lawall@...6.fr, michal.lkml@...kovi.net,
        linux-doc@...r.kernel.org, Gilles.Muller@...6.fr, corbet@....net,
        nicolas.palix@...g.fr, linux-kernel@...r.kernel.org,
        cocci@...teme.lip6.fr
Subject: Re: [Cocci] [PATCH v4 2/3] scripts: coccicheck: Change default
 condition for parallelism

On Sun, 11 Oct 2020, Sumera Priyadarsini wrote:

> Currently, Coccinelle uses at most one thread per core by default in
> machines with more than 2 hyperthreads. However, for systems with only 4
> hyperthreads, this does not improve performance.
>
> Modify coccicheck to use all available threads in machines with
> upto 4 hyperthreads.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@...il.com>

Applied, thanks.

> ---
>  scripts/coccicheck | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index d67907b8a38b..209bb0427b43 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -79,7 +79,7 @@ else
>      THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd "[:digit:]")
>      if [ -z "$J" ]; then
>          NPROC=$(getconf _NPROCESSORS_ONLN)
> -	if [ $THREADS_PER_CORE -gt 1 -a $NPROC -gt 2 ] ; then
> +	if [ $THREADS_PER_CORE -gt 1 -a $NPROC -gt 4 ] ; then
>  		NPROC=$((NPROC/2))
>  	fi
>      else
> --
> 2.25.1
>
> _______________________________________________
> Cocci mailing list
> Cocci@...teme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives