linux-kernel - Re: [Cocci] [PATCH v4 1/3] scripts: coccicheck: Add quotes to improve portability

Open Source and information security mailing list archives

Message-ID: <alpine.DEB.2.22.394.2010121038200.2901@hadrien>
Date:   Mon, 12 Oct 2020 10:38:29 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Sumera Priyadarsini <sylphrenadin@...il.com>
cc:     Julia.Lawall@...6.fr, michal.lkml@...kovi.net,
        linux-doc@...r.kernel.org, Gilles.Muller@...6.fr, corbet@....net,
        nicolas.palix@...g.fr, linux-kernel@...r.kernel.org,
        cocci@...teme.lip6.fr
Subject: Re: [Cocci] [PATCH v4 1/3] scripts: coccicheck: Add quotes to improve
 portability

On Sun, 11 Oct 2020, Sumera Priyadarsini wrote:

> While fetching the number of threads per core with lscpu,
> the [:digit:] set is used for translation of digits from 0-9.
> However, using [:digit:] instead of "[:digit:]" does not seem
> to work uniformly for some shell types and configurations
> (such as zsh).
>
> Therefore, modify coccicheck to use double quotes around the
> [:digit:] set for uniformity and better portability.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@...il.com>

Applied, thanks.

> ---
>  scripts/coccicheck | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 6789751607f5..d67907b8a38b 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -76,7 +76,7 @@ else
>      fi
>
>      # Use only one thread per core by default if hyperthreading is enabled
> -    THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd [:digit:])
> +    THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd "[:digit:]")
>      if [ -z "$J" ]; then
>          NPROC=$(getconf _NPROCESSORS_ONLN)
>  	if [ $THREADS_PER_CORE -gt 1 -a $NPROC -gt 2 ] ; then
> --
> 2.25.1
>
> _______________________________________________
> Cocci mailing list
> Cocci@...teme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives