| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <DB8PR04MB67950A459A08343CA3A779A4E6070@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date: Mon, 12 Oct 2020 10:03:02 +0000
From: Joakim Zhang <qiangqing.zhang@....com>
To: John Garry <john.garry@...wei.com>,
"acme@...nel.org" <acme@...nel.org>,
"will@...nel.org" <will@...nel.org>,
"mark.rutland@....com" <mark.rutland@....com>,
"jolsa@...hat.com" <jolsa@...hat.com>,
"irogers@...gle.com" <irogers@...gle.com>,
"leo.yan@...aro.org" <leo.yan@...aro.org>,
"peterz@...radead.org" <peterz@...radead.org>,
"mingo@...hat.com" <mingo@...hat.com>,
"alexander.shishkin@...ux.intel.com"
<alexander.shishkin@...ux.intel.com>,
"namhyung@...nel.org" <namhyung@...nel.org>,
"mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>
CC: "linuxarm@...wei.com" <linuxarm@...wei.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"zhangshaokun@...ilicon.com" <zhangshaokun@...ilicon.com>,
"james.clark@....com" <james.clark@....com>,
dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH RFC v4 13/13] perf vendor events: Add JSON metrics for
imx8mm DDR Perf
> -----Original Message-----
> From: John Garry <john.garry@...wei.com>
> Sent: 2020年10月8日 18:15
> To: acme@...nel.org; will@...nel.org; mark.rutland@....com;
> jolsa@...hat.com; irogers@...gle.com; leo.yan@...aro.org;
> peterz@...radead.org; mingo@...hat.com;
> alexander.shishkin@...ux.intel.com; namhyung@...nel.org;
> mathieu.poirier@...aro.org
> Cc: linuxarm@...wei.com; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; Joakim Zhang
> <qiangqing.zhang@....com>; zhangshaokun@...ilicon.com;
> james.clark@....com; dl-linux-imx <linux-imx@....com>; John Garry
> <john.garry@...wei.com>
> Subject: [PATCH RFC v4 13/13] perf vendor events: Add JSON metrics for
> imx8mm DDR Perf
>
> From: Joakim Zhang <qiangqing.zhang@....com>
>
> Add JSON metrics for imx8mm DDR Perf.
>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
> .../arch/arm64/freescale/imx8mm/sys/ddrc.json | 39 +++++++++++++++++++
> .../arm64/freescale/imx8mm/sys/metrics.json | 18 +++++++++
> tools/perf/pmu-events/jevents.c | 1 +
> 3 files changed, 58 insertions(+)
> create mode 100644
> tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/ddrc.json
> create mode 100644
> tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/metrics.json
>
> diff --git
> a/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/ddrc.json
> b/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/ddrc.json
> new file mode 100644
> index 000000000000..3404a880542d
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/ddrc.json
> @@ -0,0 +1,39 @@
> +[
> + {
> + "BriefDescription": "ddr cycles event",
> + "EventCode": "0x00",
> + "EventName": "imx8_ddr.cycles",
Could you help change to imx8mm_ddr.cycles? Thanks a lot!
> + "Unit": "imx8_ddr",
> + "Compat": "i.MX8MM"
> + },
> + {
> + "BriefDescription": "ddr read-cycles event",
> + "EventCode": "0x2a",
> + "EventName": "imx8_ddr.read_cycles",
Same here.
> + "Unit": "imx8_ddr",
> + "Compat": "i.MX8MM"
> + },
> + {
> + "BriefDescription": "ddr write-cycles event",
> + "EventCode": "0x2b",
> + "EventName": "imx8_ddr.write_cycles",
Same here.
> + "Unit": "imx8_ddr",
> + "Compat": "i.MX8MM"
> + },
> + {
> + "BriefDescription": "ddr read event",
> + "EventCode": "0x35",
> + "EventName": "imx8_ddr.read",
Same here.
> + "Unit": "imx8_ddr",
> + "Compat": "i.MX8MM"
> + },
> + {
> + "BriefDescription": "ddr write event",
> + "EventCode": "0x38",
> + "EventName": "imx8_ddr.write",
Same here.
> + "Unit": "imx8_ddr",
> + "Compat": "i.MX8MM"
> + }
> +]
> +
> +
> diff --git
> a/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/metrics.json
> b/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/metrics.json
> new file mode 100644
> index 000000000000..ec00212336de
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/metrics.json
> @@ -0,0 +1,18 @@
> +[
> + {
> + "BriefDescription": "bytes all masters read from ddr based on
> read-cycles event",
> + "MetricName": "imx8mm_ddr_read.all",
> + "MetricExpr": "imx8_ddr.read_cycles * 4 * 4",
> + "ScaleUnit": "9.765625e-KB",
A typo, should be "ScaleUnit": "9.765625e-4KB".
Best Regards,
Joakim Zhang
> + "Unit": "imx8_ddr",
> + "Compat": "i.MX8MM"
> + },
> + {
> + "BriefDescription": "bytes all masters write to ddr based on
> write-cycles event",
> + "MetricName": "imx8mm_ddr_write.all",
> + "MetricExpr": "imx8_ddr.write_cycles * 4 * 4",
> + "ScaleUnit": "9.765625e-4KB",
> + "Unit": "imx8_ddr",
> + "Compat": "i.MX8MM"
> + }
> +]
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 2e581bd9b0a6..b4bd48b076fd 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -257,6 +257,7 @@ static struct map {
> { "hisi_sccl,hha", "hisi_sccl,hha" },
> { "hisi_sccl,l3c", "hisi_sccl,l3c" },
> /* it's not realistic to keep adding these, we need something more
> scalable ... */
> + { "imx8_ddr", "imx8_ddr" },
> { "smmuv3_pmcg", "smmuv3_pmcg" },
> { "L3PMC", "amd_l3" },
> {}
> --
> 2.26.2
Powered by blists - more mailing lists